Open
Conversation
…real picture, as well as a link to the faq page. Will discuss in the meeting
Contributor
|
🎊 PR Preview a84eaee has been successfully built and deployed to https://CarletonComputerScienceSociety-website-build_preview-pr-502.surge.sh 🕐 Build time: 0.009s
🤖 By surge-preview |
MathyouMB
requested changes
Jun 17, 2024
| @@ -0,0 +1,9 @@ | |||
| --- | |||
Member
There was a problem hiding this comment.
this file should be named _index.md
Comment on lines
+31
to
+34
| <div class="faq__question"> | ||
| <div>{{- partial "curated-questions.html" (dict "Title" .Title "summary" .Params.summary) -}}</div> | ||
| <div>{{- partial "read-more.html" (dict "label" "Read More " "link" .RelPermalink) -}}</div> | ||
| </div> |
Member
There was a problem hiding this comment.
We seem to be loosing some of the style on this code because the old code is wrapped within the.faq-topic block.
Could we instead create a common partial with it's styling setup in any page can access it?
Comment on lines
-22
to
25
| </div> | ||
| <div class="faq-topic__questions"> | ||
| <div class="faq__questions"> | ||
| {{ range .Params.questions }} | ||
| {{ $page := printf "resources/faq/questions/%s" . }} | ||
| {{ with $.Site.GetPage $page }} |
Member
There was a problem hiding this comment.
Maybe we could create a common partial called like "faq question group" to reuse across the 2 pages
Member
|
if you run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added faq page. Still need to work on styling a little bit and add a real picture, as well as a link to the faq page. Will discuss in the meeting. Issue #495